Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deletion of lvmcluster which includes wrong paths #269

Merged
merged 1 commit into from
Sep 30, 2022
Merged

fix: deletion of lvmcluster which includes wrong paths #269

merged 1 commit into from
Sep 30, 2022

Conversation

riya-singhal31
Copy link
Contributor

@riya-singhal31 riya-singhal31 commented Sep 29, 2022 •
edited by iamniting
Loading

Deleting the lvmvolumegroup CR does not clean the VG entry in the
lvmvolumegroupnodestatus if lvmdconfig file does not exists and returns
immediately. Fix the same via updating the lvmvolumegroupnodestatus.

Signed-off-by: riya-singhal31 rsinghal@redhat.com

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2124202

iamniting
iamniting suggested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls change the commit-msg as well.

pkg/vgmanager/vgmanager_controller.go Outdated Show resolved Hide resolved
@riya-singhal31 riya-singhal31 force-pushed the lvmcluster branch 2 times, most recently from 9e0b635 to ac5a1ec Compare September 29, 2022 08:52
@riya-singhal31 riya-singhal31 changed the title fix: Can not delete lvmcluster with wrong disks path in CR fix: deleting lvmcluster successfully in case of wrong disk path in CR Sep 29, 2022
@riya-singhal31 riya-singhal31 force-pushed the lvmcluster branch 3 times, most recently from 70a8089 to bbebab4 Compare September 29, 2022 10:17
@riya-singhal31 riya-singhal31 changed the title fix: deleting lvmcluster successfully in case of wrong disk path in CR fix: delete lvmcluster successfully when CR includes wrong path Sep 29, 2022
@riya-singhal31 riya-singhal31 force-pushed the lvmcluster branch 3 times, most recently from 0cad466 to d04209b Compare September 30, 2022 07:42
iamniting
iamniting approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@iamniting
Copy link
Member

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting iamniting changed the title fix: delete lvmcluster successfully when CR includes wrong path fix: deletion of lvmcluster which includes wrong paths Sep 30, 2022
nbalacha
nbalacha reviewed Sep 30, 2022
View reviewed changes
pkg/vgmanager/vgmanager_controller.go
@@ -324,6 +324,10 @@ func (r *VGReconciler) processDelete(ctx context.Context, volumeGroup *lvmv1alph
}
if lvmdConfig == nil {
r.Log.Info("lvmd config file does not exist")
if statuserr := r.updateStatus(ctx, nil); statuserr != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here to explain why this is being done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can explain more

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

nbalacha
nbalacha suggested changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@riya-singhal31 riya-singhal31 force-pushed the lvmcluster branch 2 times, most recently from 478189e to 1eac8c0 Compare September 30, 2022 09:30
@riya-singhal31
fix: deletion of lvmcluster which includes wrong paths
8cbb4fd 
Deleting the lvmvolumegroup CR does not clean the VG entry in the
lvmvolumegroupnodestatus if lvmdconfig file does not exists and returns
immediately. Fix the same via updating the lvmvolumegroupnodestatus.

Signed-off-by: riya-singhal31 <rsinghal@redhat.com>
iamniting
iamniting approved these changes Sep 30, 2022
View reviewed changes
pkg/vgmanager/vgmanager_controller.go
@@ -324,6 +324,10 @@ func (r *VGReconciler) processDelete(ctx context.Context, volumeGroup *lvmv1alph
}
if lvmdConfig == nil {
r.Log.Info("lvmd config file does not exist")
if statuserr := r.updateStatus(ctx, nil); statuserr != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nbalacha, riya-singhal31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9bc9d38 into openshift:main Sep 30, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 30, 2022
Merged
@openshift-cherrypick-robot
Copy link

@iamniting: new pull request created: #273

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting approved these changes

@nbalacha nbalacha nbalacha approved these changes

Assignees

@nbalacha nbalacha

@iamniting iamniting

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@riya-singhal31 @iamniting @openshift-cherrypick-robot @nbalacha @openshift-merge-robot